Scheduler: oversubscribe cores just a little to make up for slack #2315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahartmetz
force-pushed
the
oversubscribe_cores_less
branch
from
fe6c4f6 to
e3f9d04
Compare
sylvestre
reviewed
Jan 10, 2025
ahartmetz
force-pushed
the
oversubscribe_cores_less
branch
2 times, most recently
from
ae01e21 to
8593012
Compare
|
We agree these CI failures are clearly unrelated to this change, right? |
lissyx
reviewed
Jan 22, 2025
ahartmetz
force-pushed
the
oversubscribe_cores_less
branch
from
8593012 to
e191d69
Compare
...not by a factor of 10 as it was done previously.
ahartmetz
force-pushed
the
oversubscribe_cores_less
branch
from
e191d69 to
9a7db5a
Compare
lissyx
approved these changes
Jan 24, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2315 +/- ##
==========================================
- Coverage 30.91% 0 -30.92%
==========================================
Files 53 0 -53
Lines 20112 0 -20112
Branches 9755 0 -9755
==========================================
- Hits 6217 0 -6217
+ Misses 7922 0 -7922
+ Partials 5973 0 -5973 ☔ View full report in Codecov by Sentry. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...not by factor of 10 as it was done previously