Solve CVE-2022-27191 and replace x/crypto/openpgp #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version past CVE-2022-27191. Signed-off-by: Hidde Beydals <hello@hidde.co>
Latest API clients are (most) often greatest. Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
As `golang.org/x/crypto/openpgp` has been deprecated (see golang/go#44226 for details). Signed-off-by: Hidde Beydals <hello@hidde.co>
ajvb
approved these changes
Apr 25, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While dependencies in
developwere recently all updated via 234bf9f, this was a tiny bit too early to cover for CVE-2022-27191.It also did not take into account that the Go crypto team has dropped the ball on OpenPGP efforts (see commit description). The folks from ProtonMail are currently maintaining a respected fork which is crucial to their business operations, and which functions as a drop-in replacement.
Updated any other outdated package as well, as they were all minor or patch bumps and thus (theoretically) backwards compatible.