Cover unsupported method with logging

Author: mpchadwick

src/provider.go

@@ -113,15 +113,15 @@ func (p Provider) raw (s string) string {
 
 	className, ok := rawProviders[parts[1]]
 	if !ok {
-		logger.Error(parts[1] + " is not a supported")
+		logger.Error(parts[1] + " is not a supported provider")
 		return ""
 	}
 
 	class := reflect.ValueOf(className)
 	methodName := strings.Split(parts[2], "(")[0]
 	method := class.MethodByName(methodName)
 	if !method.IsValid() {
-		// TODO: Cover this with logging
+		logger.Error(parts[2] + " is not a valid method")
 		return ""
 	}
 

src/provider_test.go

@@ -37,13 +37,13 @@ func TestGet(t *testing.T) {
 	}
 
 	_ = provider.Get("faker.Whoops1")
-	if hook.LastEntry().Message != "Whoops1 is not a supported" {
+	if hook.LastEntry().Message != "Whoops1 is not a supported provider" {
 		t.Errorf("Unsupported provider not handled correctly")
 	}
 
-	r6 := provider.Get("faker.Number().Whoops2()")
-	if r6 != "" {
-		t.Errorf("Got a value and was expecting empty string")
+	_ = provider.Get("faker.Number().Whoops2()")
+	if hook.LastEntry().Message != "Whoops2() is not a valid method" {
+		t.Errorf("Unsupported method not handled correctly")
 	}
 
 	r7 := provider.Get("faker.Internet().Slug")