Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Consistent naming: library vs. command line #4

Closed
mportesdev opened this issue Apr 29, 2022 · 0 comments
Closed

Consistent naming: library vs. command line #4

mportesdev opened this issue Apr 29, 2022 · 0 comments

Comments

@mportesdev
Copy link
Owner

mportesdev commented Apr 29, 2022

Currently, the library API and the command-line app use different names for the parameter used to specify the output file. (pdf_file and output-file, respectively)

It should be considered for better consistency to use the same name in both cases, e.g. change pdf_file to output_file in the signature of both PictureShow.save_pdf and pictures_to_pdf in the next minor version.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant