Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Few comments #18

Open
dzek69 opened this issue Dec 23, 2022 · 1 comment
Open

Few comments #18

dzek69 opened this issue Dec 23, 2022 · 1 comment

Comments

@dzek69
Copy link

dzek69 commented Dec 23, 2022

Hi, this idea seems lovely, but currently the implementation has some painful moments:

  • Encyrpting doubles file size, it will be probably super hard to avoid, if not impossible, but at least you should note that in README. I don't know if hacks like that: https://news.ycombinator.com/item?id=12262470 would make it possible to read the contents of the binary data, probably not, but that's something I remember reading, further research is needed

  • Encrypting freezes the browser. Opening a encrypted 9MB file (so 18MB HTML) freezes the browser. Chrome wants to kill the page when I try to focus input box - super bad UX here, not sure how could you embed this data within HTML without this. Encrypting could be moved to web workers, but with file:// protocol you have when you open local html file this is impossible. But you can at least have this for hosted HTML files I guess?

  • The encryption & decryption pages could use some nice UI design and UX. It's currently quite ugly and after using it once when decryptin all I care is the password box, yet most of the screen is covered with explainations, huge password hint, advertising product name and very cryptic (haha! a pun!) Details section

Proposed easy solution to UX:
Because there is no chance that all the people in the world would like my approach to decrypt page, which for me should look like that: https://dribbble.com/shots/5757939-Password-requirements (without the characters counter, and the text below input would be a password hint, OPTIONALLY I could display some text above the password field for first time users):

  • add a way to customize CSS
  • add a way to customize texts

Not sure how it'd be the best way to save my customizations so I don't have to copy/paste them each time.

Tell me what do you think about my thoughts

@mprimi
Copy link
Owner

mprimi commented Dec 24, 2022

I think your thoughts are great! Agree 100%

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants