Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Feedback] Notification Waktu Solat Tidak Berfungsi/Berbunyi #103

Closed
fire-bot opened this issue Mar 4, 2022 · 2 comments
Closed

[Feedback] Notification Waktu Solat Tidak Berfungsi/Berbunyi #103

fire-bot opened this issue Mar 4, 2022 · 2 comments
Labels
api External data bug Something isn't working user: crowd Received multiple request user: feedback From user feedback (eg Play Store/feedback page/email)

Comments

@fire-bot
Copy link
Collaborator

fire-bot commented Mar 4, 2022

Sent by Malaysia Prayer Time MPT (mptwaktusolat@gmail.com). Created by fire.


---------- Forwarded message ---------
Date: Wed, Mar 2, 2022 at 7:40 PM
Subject: Notification Waktu Solat Tidak Berfungsi/Berbunyi
To: <mptwaktusolat@gmail.com>

Assalamualaikum wbth, __ __


Saya salah seorang pengguna Malaysia Prayer Time 2022. __ __

Selepas saya mengemaskini (update) aplikasi tersebut beberapa hari yang lepas, __ __

saya dapati notification ketika masuk waktu solat tidak berfungsi/berbunyi seperti sebelum ini. __ __


Harap pihak tuan dapat memeriksa ataupun menaiktaraf aplikasi tersebut. __ __


Sekian, terima kasih. __ __

** ____**

____

@iqfareez
Copy link
Member

iqfareez commented Mar 4, 2022

Thank you for all user that reported to me about the issue 🔥

Sorry for late action, a lil busy.

@iqfareez iqfareez added bug Something isn't working user: crowd Received multiple request user: feedback From user feedback (eg Play Store/feedback page/email) labels Mar 4, 2022
iqfareez referenced this issue Mar 4, 2022
@iqfareez
Copy link
Member

iqfareez commented Mar 4, 2022

Alhamdulillah this issue is fixed in the latest release.

It is caused by the JAKIM api responses now uses english month.

Example before was 04-Mei-2022, now it is 04-May-2022.

Fortunately, there is no crashes etc, that's why it quite late for me to detect the error. The parser failed to parse and return the month 0, ie it will become 04-0-2022, and the rest of the code treat it as 04-12-2021 (a month before).

Refer diff a833189#diff-7af4d36a1b33e75931f0e957316707ce0a9dafcaf861f547a4a966ba73b24458

@iqfareez iqfareez closed this as completed Mar 4, 2022
@iqfareez iqfareez added the api External data label Mar 4, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
api External data bug Something isn't working user: crowd Received multiple request user: feedback From user feedback (eg Play Store/feedback page/email)
Projects
None yet
Development

No branches or pull requests

2 participants