Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Broken fragment shader in webgl_loader_nodes example #17197

Closed
4 tasks done
moraxy opened this issue Aug 7, 2019 · 4 comments
Closed
4 tasks done

Broken fragment shader in webgl_loader_nodes example #17197

moraxy opened this issue Aug 7, 2019 · 4 comments

Comments

@moraxy
Copy link
Contributor

moraxy commented Aug 7, 2019

Description of the problem

Load up example webgl_loader_nodes(dev link) and select xray in the box to the right.

THREE.WebGLShader: gl.getShaderInfoLog() fragment
ERROR: 0:774: ',' : syntax error

774: gl_FragColor = vec4( outgoingLight, pow( ( dot( , nodeU3 ) + nodeU4 ), nodeU5 ) );

Note the missing variable after dot(. The line in question seems to be

if ( alpha ) {
output.push( "gl_FragColor = vec4( outgoingLight, " + alpha.result + " );" );
} else {

where alpha.result is pow( ( dot( , nodeU3 ) + nodeU4 ), nodeU5 )

I'm getting no errors from all the default examples from webgl_materials_nodes however.

Three.js version
  • Dev
Browser
  • Chrome
  • Firefox
OS
  • Linux
@moraxy
Copy link
Contributor Author

moraxy commented Aug 7, 2019

This one is it apparently e47f073

scope view got dropped but examples/nodes/xray.json still refers to it, I guess?

@Mugen87
Copy link
Collaborator

Mugen87 commented Aug 7, 2019

/ping @sunag

@sunag
Copy link
Collaborator

sunag commented Aug 15, 2019

Sorry, for some reason I have not seen this post. VIEW scope will be added again in the next PR.

@sunag
Copy link
Collaborator

sunag commented Aug 26, 2019

Fix here 4d5fdc7 in this PR #17265

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants