Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

NodeMaterial: Roughness appears to be broken #17523

Closed
WestLangley opened this issue Sep 18, 2019 · 1 comment
Closed

NodeMaterial: Roughness appears to be broken #17523

WestLangley opened this issue Sep 18, 2019 · 1 comment
Assignees
Labels

Comments

@WestLangley
Copy link
Collaborator

git bisect suggests #17368, but there are so many commits for which the shader does not even compile, it is hard to pinpoint exactly when the error was introduced.

https://threejs.org/examples/webgl_materials_envmaps_hdr_nodes.html (set metalness to 1)

Three.js version

  • [ x ] Dev
  • [ x ] r108
@sunag
Copy link
Collaborator

sunag commented Sep 18, 2019

I fixed this in NodeMaterial r8, if I am not mistake is related with maxMipLevel, but r8 still need more work to finish...
I will create a PR to fix some issues recently.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants