Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature request: master mute toggle #356

Closed
lasselukkari opened this issue Apr 26, 2022 · 9 comments
Closed

Feature request: master mute toggle #356

lasselukkari opened this issue Apr 26, 2022 · 9 comments

Comments

@lasselukkari
Copy link
Contributor

Thank a lot for the awesome project! I use it on a daily basis to control my home stereo setup.

For similar reasons the relative gain feature was introduced I would like to be able to toggle the master mute setting. I have a rotary encoder based volume knob that emulates a keyboard. I would like to be able to toggle the master mute regardless of the current state by pressing the knob.

@lasselukkari
Copy link
Contributor Author

If you think the feature makes sense I can create a pull request myself.

@mrene
Copy link
Owner

mrene commented Apr 26, 2022

Hi! I think it makes sense, there's already command to change the master volume relative to the current one.

Did you plan on adding this to the command line interface or to the http api?

@lasselukkari
Copy link
Contributor Author

The command line interface.

@lasselukkari
Copy link
Contributor Author

How would you like it to work? Should I just extend the existing on and off parameters with toggle or do you have a better idea?

@mrene
Copy link
Owner

mrene commented Apr 27, 2022

Having toggle as a value alongside on and off seems simple enough.

@lasselukkari
Copy link
Contributor Author

Got it working. Should I do the same change for the Dirac setting as well?

@mrene
Copy link
Owner

mrene commented Apr 29, 2022

Yeah toggling dirac would make sense too.

I'm curious - what volume knob are you using?

@lasselukkari
Copy link
Contributor Author

It's this one: https://www.doukaudio.com/products/black-all-metal-usb-volume-controller-lossless-audio-vol-adjuster-for-window-mac-134. I paid 25$ including postage for it. The rotary encoder feels a bit cheap but so far it's been working fine.

@lasselukkari
Copy link
Contributor Author

Done in #359.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants