Skip to content

Commit 92b68d9

Browse files
authored
Merge pull request #336 from Trott/dere
fix: adjust inefficient regular expression
2 parents 2d1b749 + c6c0ca5 commit 92b68d9

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

src/utils/pattern.spec.ts

+1
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,7 @@ describe('Utils → Pattern', () => {
112112

113113
it('should return false for unfinished regex character class', () => {
114114
assert.ok(!util.isDynamicPattern('['));
115+
assert.ok(!util.isDynamicPattern('['.repeat(999999)));
115116
assert.ok(!util.isDynamicPattern('[abc'));
116117
});
117118

src/utils/pattern.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ const GLOBSTAR = '**';
99
const ESCAPE_SYMBOL = '\\';
1010

1111
const COMMON_GLOB_SYMBOLS_RE = /[*?]|^!/;
12-
const REGEX_CHARACTER_CLASS_SYMBOLS_RE = /\[.*]/;
12+
const REGEX_CHARACTER_CLASS_SYMBOLS_RE = /\[[^[]*]/;
1313
const REGEX_GROUP_SYMBOLS_RE = /(?:^|[^!*+?@])\(.*\|.*\)/;
1414
const GLOB_EXTENSION_SYMBOLS_RE = /[!*+?@]\(.*\)/;
1515
const BRACE_EXPANSIONS_SYMBOLS_RE = /{.*(?:,|\.\.).*}/;

0 commit comments

Comments
 (0)