perf: Avoid expensive CMSampleBuffer copy #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrousavy
added
🍏 ios
isaaccolson
pushed a commit
to isaaccolson/deliveries-mobile
that referenced
this pull request
Oct 30, 2024
* Don't copy CMSampleBuffer * Update CameraView+RecordVideo.swift * Update Podfile.lock
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For calling Frame Processors I always created a copy of the
CMSampleBuffer. I don't think this is necessary, ARC will automatically retain it until the frame processor has finished executing anyways. I also don't think video frames will be dropped, since AVFoundation maintains a pool of buffers and the frame processor does (often) not execute every single frame.This requires a bit more testing, but in general it should greatly improve the performance of frame processors, since a huge copy (~10MB per frame) is avoided.