fix: Improve Templates type

[LucasGarcez]

What

The predefined template has a generic type, so the TypeScript and autocomplete can't get a typo issue. This PR defines a literal type to register all keys and help users when using Templates.

Changes

This PR changes the Templates const type.

Tested on

Related issues

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-native-vision-camera	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 2, 2024 9:24am

[mrousavy]

Ah, lol whoops, nice catch!! thanks for the PR.

One question; could we maybe use as const at the end of the Templates declaration instead of your approach?

I'm trying to find a way that would not require me to write the keys (Video, Video60Fps, ...) twice, but instead only once and have the value type (FormatFilter[]) still be typed...?

[LucasGarcez]

Ah, lol whoops, nice catch!! thanks for the PR.

One question; could we maybe use as const at the end of the Templates declaration instead of your approach?

I'm trying to find a way that would not require me to write the keys (Video, Video60Fps, ...) twice, but instead only once and have the value type (FormatFilter[]) still be typed...?

Thanks for the quick answer. It would be great to declare the keys just once, but as far as I know, there is no resource on TypeScript to do it. If you check the TypeScript documentation for the Record utility the example is exactly the same as our use case here. So, I assume Record<Keys, Type> is the best approach.

[mrousavy]

Great, LGTM then, thank you Lucas! ❤️