Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Fix UI Thread race condition in setFrameProcessor(...) #265

Merged
merged 12 commits into from
Jul 12, 2021

Conversation

mrousavy
Copy link
Owner

@mrousavy mrousavy commented Jul 8, 2021

What

Changes

Tested on

Related issues

fixes #232

@mrousavy mrousavy force-pushed the fix/ui-thread-race-condition branch from 01e0727 to 7cab34c Compare July 8, 2021 11:21
@mrousavy mrousavy added the 🐛 bug Something isn't working label Jul 8, 2021
@mrousavy mrousavy merged commit 4b4ea0f into main Jul 12, 2021
@mrousavy mrousavy deleted the fix/ui-thread-race-condition branch July 12, 2021 13:16
isaaccolson pushed a commit to isaaccolson/deliveries-mobile that referenced this pull request Oct 30, 2024
…vy#265)

* fix: Fix UI Thread race condition in `setFrameProcessor(...)`

* Revert "fix: Fix UI Thread race condition in `setFrameProcessor(...)`"

This reverts commit 9c524e1.

* Use `setImmediate` to call `setFrameProcessor(...)`

* Fix frame processor order of applying

* Add `enableFrameProcessor` prop that defines if a FP is added

* rename constant

* Implement `enableFrameProcessor` prop for Android and make `frameProcessorFps` faster

* link to troubleshooting guide

* Update TROUBLESHOOTING.mdx

* Add logs for use-cases

* fix log

* set initial frame processor in `onLayout` instead of `componentDidMount`
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Camera start and stop issues
1 participant