-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Android] - v3.9.1 Crash on component unmount when frame processor is running🐛 #2657
Comments
Hey! I just released a new V4 beta (v4.0.0-beta.7) where I fixed a bunch of issues! 💪🚀 Can you test that and see if that fixes the issue for you? 😅
You might need to increase the |
@mrousavy this appears to be resolved in the beta. Thank you! |
Hi @mrousavy Still seeing a crash in v4.0.0-beta.7 when Camera component is unmounted and frame processor is running. But it no longer crashes in v4.0.0-beta.8! Camera component unmount also appears faster/smooter (back to v3.5.1 speed). Thanks! |
Thanks guys, great to hear that V4 now works perfectly! If you appreciate my work, please consider 💖 sponsoring me on GitHub 💖 so I can keep maintaining this library, fixing bugs and building new features! :) |
Hey - I think this issue has been fixed in VisionCamera 4.0.0. 🥳 Please try V4 and let me know if you still experience this issue;
|
What's happening?
I'm in the process of upgrading an App from RNVC v3.4.0.
The app implements a custom Frame Processor plugin using MLKit for barcode scanning. Nothing advanced - just some QR code detection plus boundary co-ordinates used for overlay drawing.
Upgrading RNVC to v3.9.1 introduced an intermittent crash when either:
To demonstrate the crash, I have added a minimal Barcode frame processor to the Example App:
https://github.com/ldstein/react-native-vision-camera/tree/crash-test
There is a new icon (Green bug icon) which toggles rendering the Camera component. Continuously tapping the bug icon will eventually lead to a crash.
Appreciate any pointers if the issue is with my frame processor implementation. Has been stable in RNVC 3.40, but that was many moons ago.
https://github.com/ldstein/react-native-vision-camera/blob/crash-test/package/example/android/app/src/main/java/com/mrousavy/camera/example/ExampleQRScannerPlugin.java
Reproduceable Code
https://github.com/ldstein/react-native-vision-camera/tree/crash-test
Relevant log output
rnvc-v3.9.1-crash-log.txt
Camera Device
Device
Pixel 3, Pixel 3 XL
VisionCamera Version
3.9.1
Can you reproduce this issue in the VisionCamera Example app?
Yes
Additional information
The text was updated successfully, but these errors were encountered: