fix: Fix Frame Processor null-dereference error (use ref-counted JNI local_ref)
#351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrousavy
added
🐛 bug
mrousavy
changed the title
local_ref)
4 tasks
This was referenced Aug 20, 2021
|
works like a charm \o/ |
|
are you sure? did you test it long enough? can't believe that did the trick |
|
me neither, it's been running for about 15 minutes now |
isaaccolson
pushed a commit
to isaaccolson/deliveries-mobile
that referenced
this pull request
Oct 30, 2024
isaaccolson
pushed a commit
to isaaccolson/deliveries-mobile
that referenced
this pull request
Oct 30, 2024
…ted JNI `local_ref`) (mrousavy#351)" This reverts commit d06bcf6.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
With #350 it looks like a null-pointer has been tried to access. This happens randomly, after maybe 5 mins or so.
My gut feeling tells me that this is the Java garbage collector running exactly at the point where a frame processor is being invoked, and since we only pass the frame, the parameters and the return values as
alias_ref(non-ref counted pointers), Java thinks it can delete those values. Now I tried using a thread specific ref-counted pointer (local_ref) and it seems like everything is working - need feedback from #350's OP first though.Changes
Tested on
Related issues