Required Actions (squashed relevant commits from pr 123) #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomrutsaert
changed the title
tomrutsaert
commented
Jun 25, 2019
|
|
||
| if !serverInfo.providerInstalled("required-action", requiredAction.Alias) { | ||
| return fmt.Errorf("validation error: required action \"%s\" does not exist on the server, installed providers: %s", requiredAction.Alias, serverInfo.getInstalledProvidersNames("required-action")) | ||
| } |
There was a problem hiding this comment.
This is the extra validation check for disabled default actions
tomrutsaert
commented
Jun 25, 2019
| d.SetId(fmt.Sprintf("%s/%s", parts[0], parts[1])) | ||
|
|
||
| return []*schema.ResourceData{d}, nil | ||
| } |
There was a problem hiding this comment.
@mrparkers Please check this import function.
There was a problem hiding this comment.
Looks perfect, nice job!
|
Running |
mrparkers
approved these changes
Jun 26, 2019
|
Is it possible to assign the required action to a user or group? |
|
I just did a little bit of digging, and from the doc it seems to me that keycloak would support creating/updating required actions for users. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
squashed relevant commits from pr #123