New data_source keycloak_realm #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CircleCI failure due to #32 |
mrparkers
reviewed
Oct 3, 2019
mrparkers
reviewed
Oct 3, 2019
mkdocs.yml
Outdated
| @@ -4,6 +4,9 @@ repo_url: https://github.com/mrparkers/terraform-provider-keycloak | |||
| nav: | |||
| - Getting Started: index.md | |||
| - Data Sources: | |||
| - keycloak_openid_client: data_sources/keycloak_openid_client.md | |||
| - keycloak_openid_client_authorization_policy: data_sources/keycloak_openid_client_authorization_policy.md | |||
There was a problem hiding this comment.
So this is awkward, but there actually aren't doc files for these data sources you added. I'd appreciate a PR to add these if you're interested 😄
If not, could you remove these dead links?
There was a problem hiding this comment.
Whops! My mistake, I planned on adding those documents but I read that you were working on it so I deleted the files, but I forgot to delete the links :D
I'll file a separate PR soon, for now I'm deleting the references.
PR Review Co-Authored-By: Michael Parker <michael@parker.gg>
|
LGTM, thanks for the PR! Sorry again about the flaky tests |
mrparkers
approved these changes
Oct 3, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new datasource for keycloak_realm.
Acceptance test results: