feat: Support PKCE on OIDC Clients #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Could you run |
mrparkers
reviewed
Oct 24, 2019
PSanetra
force-pushed
the
pkce-support
branch
from
111c2c7 to
759984e
Compare
|
@mrparkers I have pushed your suggested changes. |
mrparkers
approved these changes
Oct 30, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the advanced OIDC client setting
Proof Key for Code Exchange Code Challenge Methodon Keycloak >= 7.0.0The setting is also applied on Keycloak versions < 7.0.0, but is ignored on those versions. (At least on Keycloak 6.0.1)
Fixes #169