Fix data source keycloak_group with nested group #334
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the PR for fixing #333
The fix is not "complete", when there are multiple groups that match the filter
name
, it will return the first group it found (right now using DFS). This would cause some unexpected behaviors, for example, thedata
returned would change if new groups added with have the same with thedata
group name, or in case there are multiple nested groups share the same name, there is no option to get the desired one:Unless we introduce another indicator (eg.
path
), I think this is the best we can try.Notes: I am not too familiar with Golang if you found something weird, just let me know, thanks :)