Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow commas in keycloak_custom_user_federation config #455

Merged
merged 3 commits into from
Jan 10, 2021

Conversation

PaulGgithub
Copy link
Contributor

Allow commas in keycloak_custom_user_federation config. Fixes #454

User federation config is a MultivaluedMap. A multivalued map has a key and a list of values.

The correct terraform config would be:

config = {
key = ["value1", "value2"]
}

Changing the config structure to array of strings would break existing configurations therefore only the first value is set and taken into account.

Allow commas in keycloak_custom_user_federation config

User federation config is a MultivaluedMap. A multivalued map
has a key and a list of values.

The correct terraform config would be:
config = {
key = ["value1", "value2"]
}

Changing the config structure to array of strings would break
existing configurations therefore only the first value is
set and taken into account.
@PaulGgithub PaulGgithub changed the title Allow commas in keycloak_custom_user_federation config (#3) Allow commas in keycloak_custom_user_federation config Jan 9, 2021
Copy link
Contributor

@mrparkers mrparkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@mrparkers mrparkers merged commit dca3ac4 into keycloak:master Jan 10, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[keycloak_custom_user_federation] config not allowing commas
2 participants