-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Feature: default_roles
in keycloak_realm
resource & data source
#599
Conversation
Signed-off-by: Vlad Kirichenko <v.kirichenko@napoleongames.be>
default_roles
in keycloak_realm
resource & data sourcedefault_roles
in keycloak_realm
resource & data source
Signed-off-by: Vlad Kirichenko <v.kirichenko@napoleongames.be>
Would be nice to have default client roles as well 😄 |
Signed-off-by: Vlad Kirichenko <v.kirichenko@napoleongames.be>
…keycloak into default-roles
Signed-off-by: Vlad Kirichenko <v.kirichenko@napoleongames.be>
Signed-off-by: Vlad Kirichenko <v.kirichenko@napoleongames.be>
Signed-off-by: Vlad Kirichenko <v.kirichenko@napoleongames.be>
…keycloak into default-roles
Hi @mrparkers. Something strange is happening with the tests in circleCI. While on my local environment tests related to this PR works.(tested with keycloak version 13.0.1, 14.0.0 and 15.0.2) Can you pay attention to this? |
Don't worry about any of the failing tests that you didn't touch, sometimes the tests are flaky or Keycloak throws random 500 errors here and there. Restarting the CI workflow usually resolves that. Regarding the tests you added that are failing - I think the reason they're failing is because these tests make changes to a realm (what roles are assigned by default), so it's possible for these tests to make changes in a way that affects the results of other running tests. I went ahead and opened #608 with the contents of this branch plus some additional changes (https://github.com/mrparkers/terraform-provider-keycloak/pull/608/files#diff-38017bff6c2fe290880e2924576aeebc5b4d3d7f17ae33cb128bde82ed4aeacdR94-R97) to test this out in CI. These tests are passing because they're isolated to a specific realm, so they can't bleed into other tests. |
Signed-off-by: Vlad Kirichenko <v.kirichenko@napoleongames.be>
Signed-off-by: Vlad Kirichenko <v.kirichenko@napoleongames.be>
…keycloak into default-roles
Hi @mrparkers, can you please review this PR? |
Thanks for your work on this @Vlad-Kirichenko - I'm going to make a few changes and cut a release today |
Hello @mrparkers.
Changes in this PR gonna implement feature mentioned in #324.(Realm level roles assigned to new users)
Best regards,
Vlad