Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: Add support for frontchannel logout url. #644

Merged
merged 2 commits into from
Feb 1, 2022
Merged

feat: Add support for frontchannel logout url. #644

merged 2 commits into from
Feb 1, 2022

Conversation

oysteinhauan
Copy link
Contributor

@oysteinhauan oysteinhauan commented Jan 20, 2022 •
edited
Loading

Back again!
Frontchannel logout was added in Keycloak v15.

Also bumped github.com/hashicorp/terraform-plugin-sdk/v2 v2.7.0 -> v2.10.1

@oysteinhauan
Copy link
Contributor Author

Not sure why the 13.0.1 acceptance test fails.
Could be because of the new terraform-plugin-sdk version.
But since Keycloak version 16 was released some time ago, version 13 may not need official support anymore?

mrparkers
mrparkers approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@mrparkers mrparkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The failing test was just flaky, it was fine after I ran it again and merged master with your branch.

@mrparkers mrparkers merged commit c961941 into keycloak:master Feb 1, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mrparkers mrparkers mrparkers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oysteinhauan @mrparkers