Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

ConcurrencyCheck vs Timestamp attribute #20

Closed
buchatsky opened this issue Apr 17, 2022 · 1 comment
Closed

ConcurrencyCheck vs Timestamp attribute #20

buchatsky opened this issue Apr 17, 2022 · 1 comment
Labels
bug Something isn't working released Issue is resolved in a current release
Milestone
4.2

Comments

@buchatsky
Copy link

buchatsky commented Apr 17, 2022 •
edited
Loading

Current behaviour
"Is Concurrency Token" = true generates [ConcurrencyCheck] attribute for timestamp (RowVersion) field which leaves this field as updatable

Proposed behaviour
"Concurrency Type" field instead with 3 values:

  • None
  • Timestamp
  • Concurrency Check

Versions
EF Visual Editor: 4.1.2.0
Visual Studio 2022: 17.1.3
EntityFrameworkCore: 6.0.3
@buchatsky
Copy link
Author

And the connected issue: when "Concurrency Type"=Timestamp, the "Required" attribute should not be added on this field. Otherwise ModelState validation brings an error "RowVersion field is not set" despite it is auto-generated in DB

@msawczyn msawczyn added bug Something isn't working enhancement-M New feature request. Tshirt size: M labels Jun 27, 2022
@msawczyn msawczyn added this to the 4.2 milestone Jul 5, 2022
@msawczyn msawczyn added pending release Issue is resolved in the current codebase, will be published with the next release and removed enhancement-M New feature request. Tshirt size: M labels Jul 5, 2022
@msawczyn msawczyn added released Issue is resolved in a current release and removed pending release Issue is resolved in the current codebase, will be published with the next release labels Aug 13, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working released Issue is resolved in a current release
Projects
None yet
Milestone
4.2
Development

No branches or pull requests
2 participants
@msawczyn @buchatsky