-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Document changes in release 5.11.22 #764
Comments
Hi, CaDiCaL and Cadiback are needed for backbone detection. I can't remove it. Bumping a more serious version number would be appropriate. I will do that soon. I am sad it doesn't work for Windows, but I can't help it, I need backbone detection for model counting. If you want to, you can fix cadical and cadiback, simply create a pull request for the pypi build and I'll be happy to review and merge it. Then it will work, if you fix it. Unfortunately, I don't have the capacity to do that right now. I am closing because I can't fix this issue without many days, if not week(s) of work, and that's too much. I simply don't have that time, and absolutely nobody is paying me to do this, it's 100% my free time that I should be spending with friends and loved ones. I hope you can create a pull request to fix and then I'll be happy to review. I wish you luck and looking forward to the pull request, Mate |
Thanks for the clarification! I did not ask to remove these libraries, I was asking to clarify what were they used for, ideally in the release notes. How did backbone detection work in the previous release 5.11.21? |
Using Msys64 (MingGW), the following will build CaDiCal under Windows:
|
@a1880 According to the cadical build instructions one should do I did not say that it is not possible to compile cadical for windows, I just said it is not easy to do. And this method is officially not supported. |
I think I am making progress here. I have managed to compile the beast for Linux and Mac for pypi. Maybe Windows won't be so bad. Perhaps WSL will do the trick? I'll see... We need to fight the |
Could you, please, provide a more detailed change log for the latest version 5.11.22?
It looks like two additional dependencies
cadical
andcadiback
are now required for the build. What are these libraries used for? Sincecadical
is not easy to build under windows, this means this platform has now been dropped. I find it quite a significant change for a point release.Can you provide a bit more details about the bugs that have been fixed? If we get stuck with the previous version under windows, it would be nice to be aware about these bugs.
The text was updated successfully, but these errors were encountered: