Pull_Request Template #10
Conversation
Rename ansible-ressource -> virtualbox
Add a link to my first article
|
Can you add the license part (see CONTRIBUTING.md)? |
Oh yes no problem :D |
I have add the |
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| # License | ||
| ###### The [license](https://github.com/mtorials/hugo-mt32/blob/master/CONTRIBUTING.md) | ||
| * [ ] I agree with the license | ||
| * [ ] I do not agree with the license |
There was a problem hiding this comment.
but already .... I think it is better if you know the responsible user again agrees. disagree = no merge.
There was a problem hiding this comment.
But if the user does not agree then I will not merge it anyway
There was a problem hiding this comment.
True. You close the pr and finish.
There was a problem hiding this comment.
I think you find that is not a good idea and i should remove them?
There was a problem hiding this comment.
Just should just remove the option to disagree. I want the option to agree! (even though it is not an option). I want everyone to say: "I agree to the license" or something similar
|
I have see your merge conflict files, but i cant see the problem. You can merge them. In my next pr i want to make it clearly. Git on visual studio code was made a lot of shit, but i have already fix it. (sorry) |
|
The problem is when I merge it now your README is gone.... |
No problem! I have add the readme to this pr. You can merge |
Good Morning,
in my template pull request i have a template file for you. In the future mt32.net authors can make a structured pull request for you.