Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[LineChart] Latest version prints React warnings #13611

Closed
Janpot opened this issue Jun 24, 2024 · 5 comments
Closed

[LineChart] Latest version prints React warnings #13611

Janpot opened this issue Jun 24, 2024 · 5 comments
Labels
bug 🐛 Something doesn't work component: charts This is the name of the generic UI component, not the React module! regression A bug, but worse

Comments

@Janpot
Copy link
Member

Janpot commented Jun 24, 2024

Steps to reproduce

Link to live example: https://codesandbox.io/p/sandbox/billowing-fog-39pdzs?file=%2Fsrc%2FDemo.tsx

Steps:

  1. Open the example
  2. Check the console

Current behavior

It prints

Warning: Unknown event handler property `onAreaClick`. It will be ignored.
...

and

Warning: Unknown event handler property `onMarkClick`. It will be ignored.
...

Expected behavior

No warnings printed

Context

Discovered because it broke the Toolpad tests during last renovate upgrade cycle: https://app.circleci.com/pipelines/github/mui/mui-toolpad/15000/workflows/7cb28836-1265-47b2-838d-9dc1d8376bf5/jobs/69929?invite=true#step-106-25841_89

Would recommend setting up the tests to catch these warnings by default.

Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: onMarkClick

@Janpot Janpot added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jun 24, 2024
@Janpot Janpot changed the title [LineChart] Latest version prints Recat warnings [LineChart] Latest version prints React warnings Jun 24, 2024
@Janpot

This comment was marked as off-topic.

@alexfauquette
Copy link
Member

The error got fixed today in #13609

But I keep the issue open until we add the testing script

@alexfauquette alexfauquette added bug 🐛 Something doesn't work component: charts This is the name of the generic UI component, not the React module! regression A bug, but worse and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jun 24, 2024
@si-saaref
Copy link

I'm still facing this error..
Is the bug already got fixed or not?

@alexfauquette
Copy link
Member

The fxed version should be published during the day

Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug 🐛 Something doesn't work component: charts This is the name of the generic UI component, not the React module! regression A bug, but worse
Projects
None yet
Development

No branches or pull requests

3 participants