Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix a typo in Sultangazi/Istanbul neighbourhoods #10

Open
Kolahzary opened this issue Mar 29, 2024 · 1 comment
Open

Fix a typo in Sultangazi/Istanbul neighbourhoods #10

Kolahzary opened this issue Mar 29, 2024 · 1 comment

Comments

@Kolahzary
Copy link

For the following neighborhoods of Sultangazi/Istanbul, one of them is written with "b" and the other one is written with "p":

  • Eski Habipler Mah
  • Habibler Mah
    image

If you take a look at Sultangazi Belediye website, you see that both of their names are with b.

Also, we were doing some data migrations on our website, and we had a bug because of this, when we looked at the addresses in that neighborhood, we understood that users are usually writing it as "Eski Habibler Mah" in their address text. so I guess the correct version is "b".

Thanks for maintaining this list, it's very useful for us.

@muratgozel
Copy link
Owner

muratgozel commented Mar 31, 2024

hey @Kolahzary im glad this lib has been useful to you. i made some major improvements in the package. hopefully it won't break anything in your end.

on your issue: including "Eski Habipler" and "Habibler", all names are special names and normally they should stay as they are. you get migration errors probably because data source updated them (location name changed to something else).

my suggestion would be to keep the old information as it is and try not to match with new data. if this library starts to transform the data it got from the data source, things might get more complicated as data source update the data.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants