From 69837dece8052d495fe7dae225f175668b45761a Mon Sep 17 00:00:00 2001 From: murosan <18212747+murosan@users.noreply.github.com> Date: Sun, 16 Jun 2024 11:53:28 +0900 Subject: [PATCH 1/2] fix filter for receiver func --- rewrite.go | 4 +++- testdata/cases/12/expected/main.go | 12 ++++++++++++ testdata/cases/12/input/main.go | 14 ++++++++++++++ 3 files changed, 29 insertions(+), 1 deletion(-) create mode 100644 testdata/cases/12/expected/main.go create mode 100644 testdata/cases/12/input/main.go diff --git a/rewrite.go b/rewrite.go index bb8ac74..9fb5de8 100644 --- a/rewrite.go +++ b/rewrite.go @@ -135,10 +135,12 @@ func (f *Filter) funcRecvKey(expr ast.Expr) string { return expr.Name case *ast.IndexExpr: return expr.X.(*ast.Ident).Name + case *ast.IndexListExpr: + return expr.X.(*ast.Ident).Name case *ast.StarExpr: return f.funcRecvKey(expr.X) default: - panic(fmt.Sprintf("unknown expr type (%T)", expr)) + panic(fmt.Sprintf("unknown expr type (%T)%v", expr, expr)) } } diff --git a/testdata/cases/12/expected/main.go b/testdata/cases/12/expected/main.go new file mode 100644 index 0000000..a72eb80 --- /dev/null +++ b/testdata/cases/12/expected/main.go @@ -0,0 +1,12 @@ +package main + +func main() { + (&S[int, string]{}).f1() +} + +type S[T, U any] struct { + t T + u U +} + +func (s S[T, U]) f1() {} diff --git a/testdata/cases/12/input/main.go b/testdata/cases/12/input/main.go new file mode 100644 index 0000000..628acb5 --- /dev/null +++ b/testdata/cases/12/input/main.go @@ -0,0 +1,14 @@ +package main + +func main() { + (&S[int, string]{}).f1() +} + +type S[T, U any] struct { + t T + u U +} + +func (s S[T, U]) f1() {} + +func (s *S[T, U]) f2() {} From 0494ad5cfba688c982f3e0160c03954b12327c3e Mon Sep 17 00:00:00 2001 From: murosan <18212747+murosan@users.noreply.github.com> Date: Sun, 16 Jun 2024 11:57:34 +0900 Subject: [PATCH 2/2] no trigger on push --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 479945c..c7a6833 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,5 +1,5 @@ name: CI -on: [push, pull_request] +on: [pull_request] jobs: test: name: CI