Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Rename isPointContainedWithRightBezelRect #269

Closed
shoecart opened this issue Jun 26, 2014 · 1 comment
Closed

Rename isPointContainedWithRightBezelRect #269

shoecart opened this issue Jun 26, 2014 · 1 comment
Milestone
0.5.7

Comments

@shoecart
Copy link

MMDrawerController.m
isPointContainedWithRightBezelRect
should probably be renamed
isPointContainedWithinRightBezelRect

Just ran into the issue when subclassing and needing custom bezel detection. I couldn't figure out why the right bezel wasn't working until I realized it has a slightly different name than the other point testing functions. With vs Within.
kcharwood added a commit that referenced this issue Aug 25, 2014
@kcharwood
Fixed misnamed method isPointContainedWithinRightBezelRect (#269)
0c86c00
@kcharwood
Copy link
Contributor

Fixed in 0c86c00

🍻

@kcharwood kcharwood added this to the 0.5.7 milestone Aug 25, 2014
boherna added a commit to boherna/MMDrawerController that referenced this issue Sep 21, 2014
@boherna
Merge branch 'master' of https://github.com/mutualmobile/MMDrawerCont…
fb739e9 
…roller

# By Kevin Harwood (4) and Andrej Mihajlov (1)
# Via Kevin Harwood
* 'master' of https://github.com/mutualmobile/MMDrawerController:
  Updated podspec
  Updated changelog and readme
  Updated README with Bounce Information
  Fixed misnamed method isPointContainedWithinRightBezelRect (mutualmobile#269)
  Do not forward appearance events to central VC when drawer is offscreen
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.7
Development

No branches or pull requests
2 participants
@kcharwood @shoecart