From 4da554292361bc47aa03079a0084291642ecfcd9 Mon Sep 17 00:00:00 2001
From: Marvin Mager <99667992+mvnmgrx@users.noreply.github.com>
Date: Thu, 9 Mar 2023 21:11:34 +0100
Subject: [PATCH 1/2] Items/Common: Made Property.id optional

---
 src/kiutils/items/common.py | 23 +++++++++++++----------
 1 file changed, 13 insertions(+), 10 deletions(-)

diff --git a/src/kiutils/items/common.py b/src/kiutils/items/common.py
index 81fde3f..c843ab3 100644
--- a/src/kiutils/items/common.py
+++ b/src/kiutils/items/common.py
@@ -299,7 +299,7 @@ class Font():
 
     color: Optional[ColorRGBA] = None
     """The optional ``color`` token specifies the color of the text element
-    
+
     Available since KiCad v7"""
 
     @classmethod
@@ -451,8 +451,8 @@ class Effects():
     """The optional ``hide`` token defines if the text is hidden"""
 
     href: Optional[str] = None
-    """The optional ``href`` token specifies a link that the text element represents. 
-    
+    """The optional ``href`` token specifies a link that the text element represents.
+
     Available since KiCad v7"""
 
     @classmethod
@@ -810,8 +810,10 @@ class Property():
     value: str = ""
     """The ``value`` string defines the value of the property"""
 
-    id: int = 0
-    """The id token defines an integer ID for the property and must be unique"""
+    id: Optional[int] = None
+    """The ``id`` token defines an integer ID for the property and must be unique.
+
+    Optional since KiCad v7, but required in older versions"""
 
     position: Position = field(default_factory=lambda: Position(angle=0))
     """The ``position`` defines the X and Y coordinates as well as the rotation angle of the property.
@@ -863,8 +865,9 @@ def to_sexpr(self, indent: int = 4, newline: bool = True) -> str:
         endline = '\n' if newline else ''
 
         posA = f' {self.position.angle}' if self.position.angle is not None else ''
+        id = f' (id {self.id})' if self.id is not None else ''
 
-        expression =  f'{indents}(property "{dequote(self.key)}" "{dequote(self.value)}" (id {self.id}) (at {self.position.X} {self.position.Y}{posA})'
+        expression =  f'{indents}(property "{dequote(self.key)}" "{dequote(self.value)}"{id} (at {self.position.X} {self.position.Y}{posA})'
         if self.effects is not None:
             expression += f'\n{self.effects.to_sexpr(indent+2)}'
             expression += f'{indents}){endline}'
@@ -1005,13 +1008,13 @@ def to_sexpr(self, indent: int = 4, newline: bool = True) -> str:
 @dataclass
 class Fill():
     """The ``fill`` token defines how schematic and symbol graphical items are filled
-    
-    Documentation: 
+
+    Documentation:
         - https://dev-docs.kicad.org/en/file-formats/sexpr-intro/index.html#_fill_definition
     """
 
     type: str = "none"
-    """The ``type`` attribute defines how the graphical item is filled. Defaults to ``None``. 
+    """The ``type`` attribute defines how the graphical item is filled. Defaults to ``None``.
     Possible values are:
     - ``none``: Graphic is not filled
     - ``outline``: Graphic item filled with the line color
@@ -1019,7 +1022,7 @@ class Fill():
 
     color: Optional[ColorRGBA] = None
     """The optional ``color`` token defines the color of the filled item.
-    
+
     Available since KiCad v7"""
 
     @classmethod

From e530e15f51d8ba1f8044d53c74f4aa4afca24edb Mon Sep 17 00:00:00 2001
From: Marvin Mager <99667992+mvnmgrx@users.noreply.github.com>
Date: Thu, 9 Mar 2023 21:15:20 +0100
Subject: [PATCH 2/2] Items/Common: Docu in Property class

---
 src/kiutils/items/common.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/kiutils/items/common.py b/src/kiutils/items/common.py
index c843ab3..72ebe0d 100644
--- a/src/kiutils/items/common.py
+++ b/src/kiutils/items/common.py
@@ -820,7 +820,7 @@ class Property():
     All three items will initially be set to zero."""
 
     effects: Optional[Effects] = None
-    """The ``effects`` section defines how the text is displayed"""
+    """The optional ``effects`` section defines how the text is displayed"""
 
     @classmethod
     def from_sexpr(cls, exp: list) -> Property: