Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Do not trigger (a skipped run of) the Update Playwright Snapshots action on every comment #1348

Open
mwouts opened this issue Mar 9, 2025 · 2 comments
Milestone

Comments

@mwouts
Copy link
Owner

mwouts commented Mar 9, 2025

We see many skipped runs of the Update Playwright Snapshots action at https://github.com/mwouts/jupytext/actions:

Image

@mahendrapaipuri do you see how we could address that? Thank you!

@mwouts mwouts changed the title Do not trigger (a skip run of) the Update Playwright Snapshots action on every comment Do not trigger (a skipped run of) the Update Playwright Snapshots action on every comment Mar 9, 2025
@mwouts mwouts added this to the 1.17.0 milestone Mar 9, 2025
@mahendrapaipuri
Copy link
Collaborator

@mwouts I think it is due to the trigger event that the workflow is looking at. If we look at the workflow file, it listens for comments and check if the update snaphots is found in issue comment. So, I think it is normal that it runs on every comment and eventually skips it if it does not find the "key words". Not sure if there is a better way to do it, but I will look into it!

@mwouts
Copy link
Owner Author

mwouts commented Mar 9, 2025

I see, thank you @mahendrapaipuri - this is mostly fine, the only "issue" is that is makes it a bit harder to search for past CI runs - I know that can click on "CI" to avoid this, was just curious to see if we could make this a bit less verbose, not urgent anyway!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants