Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Better error message when calling data transformation functions on a null value #10210

Conversation

michael-radency
Copy link
Contributor

@michael-radency michael-radency added the n8n team Authored by the n8n team label Jul 26, 2024
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

cypress bot commented Jul 26, 2024

Passing run #6166 ↗︎

0 389 0 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Project: n8n Commit: 68cd275f1a
Status: Passed Duration: 04:13 💡
Started: Jul 26, 2024 3:55 PM Ended: Jul 26, 2024 4:00 PM

Review all test suite changes for PR #10210 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit 1718125 into master Jul 26, 2024
27 checks passed
@michael-radency michael-radency deleted the node-1497-expressions-better-error-message-when-calling-data branch July 26, 2024 17:04
MiloradFilipovic added a commit that referenced this pull request Jul 29, 2024
* master:
  feat(HTTP Request Node): Add option to disable lowercase headers (#10154)
  feat: Recovery option for jsonParse helper (#10182)
  fix: Better error message when calling data transformation functions on a null value (#10210)
  refactor: Delete mistakenly commited node file (no-changelog) (#10213)
  refactor(editor): Add Infisical deprecation notice (#10191)
  feat(editor): Show new executions as `Queued` in the UI, until they actually start (#10204)
  refactor: Update Langchain modules & add Ollama tools support (#10208)
  feat(Sentiment Analysis Node): Implement Sentiment Analysis node (#10184)
  fix: Add original error message to messages, do not obfuscate if description provided in options (no-changelog) (#10202)
  fix(Google Sheets Node): Fix Google Sheet URL regex (#10195)
  fix(Google Sheets Node): Add column names row if sheet is empty (#10200)
  fix(Google Sheets Node): Do not insert row_number as a new column, do not checkForSchemaChanges in update operation (#10201)
  docs: Update credential urls (no-changelog) (#10193)
  fix(editor): Add back prompt requesting to save unsaved changes (no-changelog) (#10190)
  fix(HTTP Request Node): Resolve max pages expression (#10192)
cstuncsik pushed a commit that referenced this pull request Jul 31, 2024
@github-actions github-actions bot mentioned this pull request Jul 31, 2024
@janober
Copy link
Member

janober commented Jul 31, 2024

Got released with n8n@1.53.0

cstuncsik pushed a commit that referenced this pull request Aug 1, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants