Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(core): Fix expressions in webhook nodes(Form, Webhook) to access previous node's data #10247

Conversation

michael-radency
Copy link
Contributor

@michael-radency michael-radency commented Jul 30, 2024

Summary

Trying to use expression like {{ $json.someProp }} in Wait node, when using Form resume mode, resolves in error thrown
Resolve $execution in Wait node

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1539/fix-expressions-in-webhook-nodesform-webhook-to-access-previous-nodes

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jul 30, 2024
@netroy netroy changed the title fix: Fix expressions in webhook nodes(Form, Webhook) to access previous node's data fix(core): Fix expressions in webhook nodes(Form, Webhook) to access previous node's data Aug 1, 2024
Copy link

cypress bot commented Aug 1, 2024



Test summary

390 0 0 0Flakiness 0


Run details

Project n8n
Status Passed
Commit 1fa5ab1
Started Aug 1, 2024 8:05 AM
Ended Aug 1, 2024 8:09 AM
Duration 04:37 💡
OS Linux Debian -
Browser Electron 118

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link
Contributor

github-actions bot commented Aug 1, 2024

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit 88a1701 into master Aug 1, 2024
28 checks passed
@michael-radency michael-radency deleted the node-1539-fix-expressions-in-webhook-nodesform-webhook-to-access branch August 1, 2024 08:22
MiloradFilipovic added a commit that referenced this pull request Aug 1, 2024
* master:
  refactor(core): Decouple workflow created, saved, deleted events from internal hooks (no-changelog) (#10264)
  fix(core): Fix oauth2 callback and add integration tests (no-changelog) (#10272)
  fix(n8n Form Trigger Node): Improve copy and a few tweaks (no-changelog) (#10243)
  fix(core): Fix expressions in webhook nodes(Form, Webhook) to access previous node's data (#10247)
  refactor(core): Port endpoints config (no-changelog) (#10268)
  feat(AWS Lambda Node): Add support for paired items (no-changelog) (#10270)
  fix: Loop node no input data shown (#10224)
  fix(core): Make OAuth1/OAuth2 callback not require auth (#10263)
  🚀 Release 1.53.0 (#10266)
  fix(core): Upgrade @n8n/vm2 to address CVE‑2023‑37466 (#10265)
  feat(Calendly Trigger Node): Add OAuth Credentials Support (#10251)
  test(core): Improve and expand log streaming tests (no-changelog) (#10261)
  refactor(editor): Migrate `WorkflowExecutionsListView.vue` to composition API (no-changelog) (#10198)
  fix(core): Restore log event `n8n.workflow.failed` (#10253)
  test(core): Stop showing JWT warning during test runs (no-changelog) (#10255)
  fix(Postgres Node): Expressions in query parameters for Postgres executeQuery operation (#10217)
  fix(editor): Fix workflow execution list scrolling after filter change (#10226)
@github-actions github-actions bot mentioned this pull request Aug 7, 2024
@janober
Copy link
Member

janober commented Aug 7, 2024

Got released with n8n@1.54.0

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants