-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(Postgres Node): Account for JSON expressions #12012
fix(Postgres Node): Account for JSON expressions #12012
Conversation
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
9614fd6
to
fa94cee
Compare
27f09c0
to
166eaa8
Compare
fwiw, i'm fairly certain the codecov is complaining because I converted the loop into a map and therefore touched lines which are yet to be tested. however, code coverage is increased by 0.21% 😄 |
packages/nodes-base/nodes/Postgres/v2/actions/database/executeQuery.operation.ts
Outdated
Show resolved
Hide resolved
561f690
to
cc210b1
Compare
This will be used in a later commit
Moving stringToArray to utils should make parsing JSON be easier to test
Co-authored-by: Shireen Missi <94372015+ShireenMissi@users.noreply.github.com>
cc210b1
to
c6702ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
|
n8n Run #8434
Run Properties:
|
Project |
n8n
|
Branch Review |
node-1753-inserting-json-multiple-key-val-fails
|
Run status |
Failed #8434
|
Run duration | 04m 22s |
Commit |
c6702ececb: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 dana-gill 🗃️ e2e/*
|
Committer | Dana Lee |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
1
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
387
|
View all changes introduced in this branch ↗︎ |
Tests for review
14-mapping.cy.ts • 1 failed test
Test | Artifacts | |
---|---|---|
Data mapping > maps expressions from json view |
Test Replay
Screenshots
Video
|
The first 5 failed specs are shown, see all 35 specs in Cypress Cloud.
c6702ec
to
f204733
Compare
f204733
to
0f9922a
Compare
|
2 similar comments
|
|
✅ All Cypress E2E specs passed |
Co-authored-by: Shireen Missi <94372015+ShireenMissi@users.noreply.github.com>
Got released with |
1 similar comment
Got released with |
Got released with |
1 similar comment
Got released with |
Co-authored-by: Shireen Missi <94372015+ShireenMissi@users.noreply.github.com>
Summary
Fixes the bug where query params which include multiple JSON key/vals fails in Postgres Node
Workflows for testing:
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-1753/postgres-node-inserting-json-with-multiple-keyvalue-via-query
https://community.n8n.io/t/issue-with-inserting-json-with-multiple-key-value-pairs-in-postgresql-jsonb/53939/
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)