Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(core): Add option to filter for empty variables #12112

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

despairblue
Copy link
Contributor

Summary

When using environments and pulling down changes we create stubs for variables and credentials.

We want to give users an easy overview over all credentials and variables that still need to be filled in.

For this we're adding a filter to show "empty" variables and credentials.

This PR adds the filter for variables.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/PAY-2306/check-for-empty-credentials-or-variables

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@despairblue despairblue marked this pull request as ready for review December 9, 2024 15:48
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...es/src/dto/variables/variables-list-request.dto.ts 0.00% 3 Missing ⚠️
packages/@n8n/api-types/src/dto/index.ts 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Dec 10, 2024

n8n    Run #8264

Run Properties:  status check passed Passed #8264  •  git commit 5ebd350cc9: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 despairblue 🗃️ e2e/*
Project n8n
Branch Review pay-2306-check-for-empty-credentials-or-variables
Run status status check passed Passed #8264
Run duration 04m 30s
Commit git commit 5ebd350cc9: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 despairblue 🗃️ e2e/*
Committer Danny Martini
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 480
View all changes introduced in this branch ↗︎

@despairblue despairblue merged commit a63f0e8 into master Dec 10, 2024
37 checks passed
@despairblue despairblue deleted the pay-2306-check-for-empty-credentials-or-variables branch December 10, 2024 11:47
@github-actions github-actions bot mentioned this pull request Dec 11, 2024
@janober
Copy link
Member

janober commented Dec 11, 2024

Got released with n8n@1.72.0

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants