-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(core): Add option to filter for empty variables #12112
Merged
despairblue
merged 2 commits into
master
from
pay-2306-check-for-empty-credentials-or-variables
Dec 10, 2024
Merged
feat(core): Add option to filter for empty variables #12112
despairblue
merged 2 commits into
master
from
pay-2306-check-for-empty-credentials-or-variables
Dec 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
Enhancement outside /nodes-base and /editor-ui
n8n team
Authored by the n8n team
labels
Dec 9, 2024
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
tomi
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
✅ All Cypress E2E specs passed |
n8n Run #8264
Run Properties:
|
Project |
n8n
|
Branch Review |
pay-2306-check-for-empty-credentials-or-variables
|
Run status |
Passed #8264
|
Run duration | 04m 30s |
Commit |
5ebd350cc9: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 despairblue 🗃️ e2e/*
|
Committer | Danny Martini |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
480
|
View all changes introduced in this branch ↗︎ |
despairblue
deleted the
pay-2306-check-for-empty-credentials-or-variables
branch
December 10, 2024 11:47
Merged
Got released with |
riascho
pushed a commit
that referenced
this pull request
Jan 14, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using environments and pulling down changes we create stubs for variables and credentials.
We want to give users an easy overview over all credentials and variables that still need to be filled in.
For this we're adding a filter to show "empty" variables and credentials.
This PR adds the filter for variables.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/PAY-2306/check-for-empty-credentials-or-variables
Review / Merge checklist
Tests included.PR Labeled withrelease/backport
(if the PR is an urgent fix that needs to be backported)