Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(core): Fix support for multiple invocation of AI tools #12141

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

netroy
Copy link
Member

@netroy netroy commented Dec 10, 2024

Summary

This PR fixes issues related to when an AI tool in invoked multiple times for a parent node invocation.

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@netroy netroy force-pushed the refactor-ISupplyDataFunctions-more branch from fe4fc7d to 7036c69 Compare December 10, 2024 16:24
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 48.14815% with 28 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/core/src/NodeExecuteFunctions.ts 0.00% 26 Missing ⚠️
packages/core/src/CreateNodeAsTool.ts 90.47% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Base automatically changed from refactor-ISupplyDataFunctions to master December 11, 2024 10:26
@netroy netroy force-pushed the refactor-ISupplyDataFunctions-more branch from 7036c69 to ec8d835 Compare December 11, 2024 10:29
@netroy netroy marked this pull request as ready for review December 11, 2024 12:26
Copy link
Contributor

@OlegIvaniv OlegIvaniv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@netroy netroy changed the title refactor(core): Add support for multiple invocation of tools fix(core): Add support for multiple invocation of AI tools Dec 11, 2024
Copy link

cypress bot commented Dec 11, 2024

n8n    Run #8287

Run Properties:  status check passed Passed #8287  •  git commit ec8d835acd: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project n8n
Branch Review refactor-ISupplyDataFunctions-more
Run status status check passed Passed #8287
Run duration 04m 43s
Commit git commit ec8d835acd: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Committer Oleg Ivaniv
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 480
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit c572c06 into master Dec 11, 2024
43 checks passed
@netroy netroy deleted the refactor-ISupplyDataFunctions-more branch December 11, 2024 12:47
@netroy netroy changed the title fix(core): Add support for multiple invocation of AI tools fix(core): Fix support for multiple invocation of AI tools Dec 11, 2024
@github-actions github-actions bot mentioned this pull request Dec 11, 2024
@janober
Copy link
Member

janober commented Dec 11, 2024

Got released with n8n@1.72.0

ivov pushed a commit that referenced this pull request Dec 12, 2024
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
@github-actions github-actions bot mentioned this pull request Dec 12, 2024
riascho pushed a commit that referenced this pull request Jan 14, 2025
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants