Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(AI Agent Node): Update descriptions and titles for Chat Trigger options in AI Agents and Memory #12155

Merged
merged 5 commits into from
Dec 12, 2024

Conversation

CharlieKolb
Copy link
Contributor

Summary

Update the messaging for AI Agent and Memory parameters related to using ChatTrigger automatically.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/ADO-2947/feature-tweak-the-prompt-source-parameter

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@CharlieKolb CharlieKolb changed the title feat(nodes): Update descriptions and titles for Chat Trigger options in AI Agents feat(AI Nodes): Update descriptions and titles for Chat Trigger options in AI Agents and Memory Dec 11, 2024
@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Dec 11, 2024
@CharlieKolb CharlieKolb changed the title feat(AI Nodes): Update descriptions and titles for Chat Trigger options in AI Agents and Memory feat(AI Agent Node): Update descriptions and titles for Chat Trigger options in AI Agents and Memory Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@CharlieKolb CharlieKolb marked this pull request as ready for review December 11, 2024 12:57
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor comment but good to go on my end

value: 'fromInput',
description: 'Looks for an input field called sessionId',
description:
'Looks for an input field called sessionId that is coming from a directly connected Chat Trigger',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Does it make sense to wrap the sessionId in quotes or backticks to make it standout a bit more?

Copy link

cypress bot commented Dec 12, 2024

n8n    Run #8321

Run Properties:  status check passed Passed #8321  •  git commit bb88925e8b: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 CharlieKolb 🗃️ e2e/*
Project n8n
Branch Review ADO-2947
Run status status check passed Passed #8321
Run duration 04m 38s
Commit git commit bb88925e8b: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 CharlieKolb 🗃️ e2e/*
Committer Charlie Kolb
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 480
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link
Contributor

✅ All Cypress E2E specs passed

@CharlieKolb CharlieKolb merged commit 07a6ae1 into master Dec 12, 2024
38 checks passed
@CharlieKolb CharlieKolb deleted the ADO-2947 branch December 12, 2024 13:01
@github-actions github-actions bot mentioned this pull request Dec 19, 2024
@janober
Copy link
Member

janober commented Dec 19, 2024

Got released with n8n@1.73.0

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants