Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(core): Upgrade nanoid to address CVE-2024-55565 #12171

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

netroy
Copy link
Member

@netroy netroy commented Dec 11, 2024

Summary

Advisory

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Dec 12, 2024

n8n    Run #8335

Run Properties:  status check passed Passed #8335  •  git commit a486093af4: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project n8n
Branch Review upgrade-nanoid-fix-CVE-2024-55565
Run status status check passed Passed #8335
Run duration 04m 41s
Commit git commit a486093af4: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Committer कारतोफ्फेलस्क्रिप्ट™
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 480
View all changes introduced in this branch ↗︎

@netroy netroy force-pushed the upgrade-nanoid-fix-CVE-2024-55565 branch from ddd6106 to a486093 Compare December 13, 2024 12:22
@netroy netroy requested a review from mieky December 13, 2024 12:22
Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit 8c0bd02 into master Dec 13, 2024
37 checks passed
@netroy netroy deleted the upgrade-nanoid-fix-CVE-2024-55565 branch December 13, 2024 14:15
@github-actions github-actions bot mentioned this pull request Dec 19, 2024
@janober
Copy link
Member

janober commented Dec 19, 2024

Got released with n8n@1.73.0

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants