Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(editor): Prevent connection line from showing when clicking the plus button of a node #12265

Conversation

alexgrozav
Copy link
Member

Summary

Screen.Recording.2024-12-17.at.15.39.20.mov

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/N8N-7604/when-clicking-on-the-plus-on-the-output-stalk-of-a-node-connector

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@alexgrozav alexgrozav self-assigned this Dec 17, 2024
…ing-on-the-plus-on-the-output-stalk-of-a-node
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Dec 17, 2024
Copy link

cypress bot commented Dec 17, 2024

n8n    Run #8381

Run Properties:  status check passed Passed #8381  •  git commit 6c027fb632: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Project n8n
Branch Review n8n-7604-when-clicking-on-the-plus-on-the-output-stalk-of-a-node
Run status status check passed Passed #8381
Run duration 04m 40s
Commit git commit 6c027fb632: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Committer Alex Grozav
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 481
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@alexgrozav alexgrozav merged commit 9180b46 into master Dec 17, 2024
37 checks passed
@alexgrozav alexgrozav deleted the n8n-7604-when-clicking-on-the-plus-on-the-output-stalk-of-a-node branch December 17, 2024 15:15
@github-actions github-actions bot mentioned this pull request Dec 19, 2024
@janober
Copy link
Member

janober commented Dec 19, 2024

Got released with n8n@1.73.0

riascho pushed a commit that referenced this pull request Jan 14, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants