fix(core): Fix manually running a pinned trigger with offloading enabled #12491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
n8n-assistant
bot
added
core
|
✅ All Cypress E2E specs passed |
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
pay-2442
|
| Run status |
|
| Run duration | 04m 54s |
| Commit |
|
| Committer | Iván Ovejero |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
485
|
| View all changes introduced in this branch ↗︎ | |
Merged
|
Got released with |
riascho
pushed a commit
that referenced
this pull request
Jan 14, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Until recently, manual executions in scaling mode ran in the main process, so some execution details were never persisted in the database - those details remained in memory and were used in the same process. But as #11284, we offload manual executions from mains to workers if a flag is enabled. Offloading persists manual execution details to the DB, so that the worker can retrieve them to know how to run the manual execution.
There is an edge case where, if the manual execution has one or more pinned triggers, we set the first pinned trigger in the execution details. In this case we collect execution details too early, failing to account for the pinned trigger that was set. This PR fixes this edge case.
Test
The execution flow is not yet easily testable.
To test manually:
export OFFLOAD_MANUAL_EXECUTIONS_TO_WORKERS=trueExpected: The webhook should use its pinned data the first time, and wait for a webhook the second time.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/PAY-2442/fix-manually-running-a-pinned-webhook-with-offloading-enabled
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)