Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Add ConvertAPI cred only node #12663

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Jan 17, 2025

Summary

ConvertAPI Cred only node for DevRel.

An account can be created here: https://www.convertapi.com/ with free credits for any testing.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-2252/cred-only-node-convertapi

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@dana-gill dana-gill requested a review from elsmr January 17, 2025 09:56
@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...s/nodes-base/credentials/ConvertApi.credentials.ts 0.00% 9 Missing ⚠️

📢 Thoughts on this report? Let us know!

elsmr
elsmr previously approved these changes Jan 20, 2025
Copy link

cypress bot commented Jan 20, 2025

n8n    Run #9250

Run Properties:  status check passed Passed #9250  •  git commit 478d2eb83f: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Project n8n
Branch Review node-2252-cred-only-node-convertapi
Run status status check passed Passed #9250
Run duration 04m 39s
Commit git commit 478d2eb83f: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Committer Jon
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 436
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@ShireenMissi ShireenMissi force-pushed the node-2252-cred-only-node-convertapi branch from 066ae68 to 478d2eb Compare February 12, 2025 16:09
Copy link
Contributor

✅ All Cypress E2E specs passed

@ShireenMissi ShireenMissi merged commit 731a9a7 into master Feb 12, 2025
38 of 39 checks passed
@ShireenMissi ShireenMissi deleted the node-2252-cred-only-node-convertapi branch February 12, 2025 17:34
@github-actions github-actions bot mentioned this pull request Feb 13, 2025
@janober
Copy link
Member

janober commented Feb 13, 2025

Got released with n8n@1.79.0

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants