fix(core): Add an option to enable dual-stack lookup to support IPv6 for redis #13118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
n8n-assistant
bot
added
core
Joffcom
approved these changes
Feb 7, 2025
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
CAT-627-dualstack-redis
|
| Run status |
|
| Run duration | 04m 32s |
| Commit |
|
| Committer | कारतोफ्फेलस्क्रिप्ट™ |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
434
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
Merged
|
Got released with |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ioredis uses only IPv4 by default. This PR adds an option to let users enable dual-stack lookup for the redis hostname.
Related Linear tickets, Github issues, and Community forum posts
Fixes #13117
CAT-627
https://community.n8n.io/t/allow-ipv6-to-use-redis-with-provider-internal-network/32439
https://community.n8n.io/t/allow-ipv6-to-use-redis-with-provider-internal-network-the-return/61372
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)