fix(core): Handle credential decryption failures gracefully on the API #13166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
tomi
reviewed
Feb 10, 2025
| this.errorReporter.error(error, { | ||
| level: 'error', | ||
| extra: { credentialId: credential.id }, | ||
| tags: { credentialType: credential.type }, |
There was a problem hiding this comment.
Do we want this to be a tag or extra?
There was a problem hiding this comment.
kept the type in the tags to be able to have an overview, to see if there is any pattern there.
|
✅ All Cypress E2E specs passed |
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
handle-credential-decryption-failures-gracefully
|
| Run status |
|
| Run duration | 04m 52s |
| Commit |
|
| Committer | कारतोफ्फेलस्क्रिप्ट™ |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
435
|
| View all changes introduced in this branch ↗︎ | |
Merged
|
Got released with |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If the credentials table contains any values that are either invalid JSON when decrypted, or values that fail to decrypt, the API endpoints for fetching credentials on the frontend should not crash, and instead return a
{}as decrypted data, which in turn marks these credentials with theNeeds first setuptag on the frontend, so that users can then edit and fix these credentials.Related Linear tickets, Github issues, and Community forum posts
Fixes #12949
Fixes #12940
CAT-632
CAT-616
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)