Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(core): Handle missing json property on nodeSuccessData #13219

Merged
merged 1 commit into from
Feb 12, 2025
Merged

fix(core): Handle missing json property on nodeSuccessData #13219

merged 1 commit into from
Feb 12, 2025

Conversation

netroy
Copy link
Member

@netroy netroy commented Feb 12, 2025

Summary

Addresses https://n8nio.sentry.io/issues/6287817792

Related Linear tickets, Github issues, and Community forum posts

CAT-639

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@codecov Codecov
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Feb 12, 2025
@cypress Cypress
Copy link

cypress bot commented Feb 12, 2025

n8n    Run #9248

Run Properties:  status check passed Passed #9248  •  git commit 053f498cba: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project n8n
Branch Review CAT-639
Run status status check passed Passed #9248
Run duration 04m 42s
Commit git commit 053f498cba: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Committer कारतोफ्फेलस्क्रिप्ट™
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 436
View all changes introduced in this branch ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit aedea7a into master Feb 12, 2025
37 checks passed
@netroy netroy deleted the CAT-639 branch February 12, 2025 13:09
@github-actions github-actions bot mentioned this pull request Feb 13, 2025
Merged
@janober
Copy link
Member

janober commented Feb 13, 2025

Got released with n8n@1.79.0

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ShireenMissi ShireenMissi ShireenMissi approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@netroy @janober @ShireenMissi