Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(editor): Add schema view to expression modal #9976

Merged
merged 15 commits into from
Aug 12, 2024
Merged

feat(editor): Add schema view to expression modal #9976

merged 15 commits into from
Aug 12, 2024

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Jul 9, 2024 •
edited
Loading

Summary

  • Add schema view
  • Remove variable selector
  • Add ability to drag'n'drop from schema view to a specific location in the editor
image

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1414/improved-schema-view-in-expression-editor-modal

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jul 9, 2024
@cypress Cypress
Copy link

cypress bot commented Aug 7, 2024 •
edited
Loading


Test summary

396 • 0 • 0 • 0 • Flakiness 1

Run details
Project n8n
Status Passed
Commit e98df79
Started Aug 12, 2024 2:33 PM
Ended Aug 12, 2024 2:38 PM
Duration 04:45 💡
OS Linux Debian -
Browser Electron 118

View run in Cypress Cloud ➡️

Flakiness

e2e/14-mapping.cy.ts 1 Flakiness
1 Data mapping > maps expressions from table header

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@elsmr elsmr marked this pull request as ready for review August 9, 2024 14:36
ShireenMissi
ShireenMissi approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉
Tested manually and it works as expected 👍

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@elsmr elsmr merged commit 71b6c67 into master Aug 12, 2024
47 checks passed
@elsmr elsmr deleted the node-1414-improved-schema-view-in-expression-editor-modal branch August 12, 2024 14:47
@github-actions github-actions bot mentioned this pull request Aug 14, 2024
Merged
@janober
Copy link
Member

janober commented Aug 15, 2024

Got released with n8n@1.55.0

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ShireenMissi ShireenMissi ShireenMissi approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elsmr @janober @ShireenMissi