diff --git a/cypress/e2e/17-workflow-tags.cy.ts b/cypress/e2e/17-workflow-tags.cy.ts index 88a2c9973dd66..fc889aead29c2 100644 --- a/cypress/e2e/17-workflow-tags.cy.ts +++ b/cypress/e2e/17-workflow-tags.cy.ts @@ -1,4 +1,5 @@ import { WorkflowPage } from '../pages'; +import { getVisibleSelect } from '../utils'; const wf = new WorkflowPage(); @@ -70,4 +71,20 @@ describe('Workflow tags', () => { wf.getters.workflowTags().click(); wf.getters.tagPills().should('have.length', TEST_TAGS.length - 1); }); + + it('should not show non existing tag as a selectable option', () => { + const NON_EXISTING_TAG = 'My Test Tag'; + + wf.getters.createTagButton().click(); + wf.actions.addTags(TEST_TAGS); + cy.get('body').click(0, 0); + wf.getters.workflowTags().click(); + wf.getters.tagsDropdown().find('input:focus').type(NON_EXISTING_TAG); + + getVisibleSelect() + .find('li') + .should('have.length', 2) + .filter(`:contains("${NON_EXISTING_TAG}")`) + .should('not.have.length'); + }); }); diff --git a/packages/editor-ui/src/components/MainHeader/WorkflowDetails.vue b/packages/editor-ui/src/components/MainHeader/WorkflowDetails.vue index fb103720206e5..9a5eb14dfbb5c 100644 --- a/packages/editor-ui/src/components/MainHeader/WorkflowDetails.vue +++ b/packages/editor-ui/src/components/MainHeader/WorkflowDetails.vue @@ -639,7 +639,6 @@ function showCreateWorkflowSuccessToast(id?: string) { v-if="isTagsEditEnabled && !readOnly" ref="dropdown" v-model="appliedTagIds" - :create-enabled="true" :event-bus="tagsEventBus" :placeholder="$locale.baseText('workflowDetails.chooseOrCreateATag')" class="tags-edit" diff --git a/packages/editor-ui/src/components/TagsDropdown.vue b/packages/editor-ui/src/components/TagsDropdown.vue index 0a5ac3b4933a3..bcd02fd6fa482 100644 --- a/packages/editor-ui/src/components/TagsDropdown.vue +++ b/packages/editor-ui/src/components/TagsDropdown.vue @@ -13,7 +13,6 @@ :filter-method="filterOptions" filterable multiple - :allow-create="createEnabled" :reserve-keyword="false" loading-text="..." popper-class="tags-dropdown" @@ -23,7 +22,7 @@ @remove-tag="onRemoveTag" > - {{ i18n.baseText('tagsDropdown.typeToCreateATag') }} - {{ + {{ i18n.baseText('tagsDropdown.typeToCreateATag') }} + {{ i18n.baseText('tagsDropdown.noMatchingTagsExist') }} - {{ i18n.baseText('tagsDropdown.noTagsExist') }} + {{ i18n.baseText('tagsDropdown.noTagsExist') }} @@ -90,10 +89,6 @@ export default defineComponent({ type: Array as PropType, default: () => [], }, - createEnabled: { - type: Boolean, - default: false, - }, eventBus: { type: Object as PropType, default: null,