Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Final Review Ticket #18

Open
7 of 8 tasks
nVarap opened this issue Feb 27, 2023 · 0 comments
Open
7 of 8 tasks

Final Review Ticket #18

nVarap opened this issue Feb 27, 2023 · 0 comments

Comments

@nVarap
Copy link
Owner

nVarap commented Feb 27, 2023

Final Review Ticket -- Peer and Self Grade

Deployed Website: DON'T LEAVE ME (Create an account! Find love! ❤️❤️❤️)

Part 1: Live Review with Student Crossovers (7 Points Total)

Item Self-Grade First Person (Samarth) Second Person (Ranauk) Reasoning Avg
Runtime (binary criteria below, 3 points + bonus) n/a n/a n/a n/a n/a
Observe Team project quality, runs on cross domain, performs all evaluations without crashing. 1 1 1 Runs on a deployed domain, operates completely correctly without crashing. 1
Observe, Individual UI contains inputs that are validated for garbage, data cleaned (ie validate DOB or Password) 1 1 1 The UI contains inputs, and the functions throw error when invalid emails are inputted. Validate functions also exist to ensure continuation only occurs if the function is passed 1
Observe, Individual UI contains actions for Create, Read 1 1 1 UI Actively has textbooks that can be used to create, and text boxes that use promises to fill out certain text boxes by reading from the Database 1
Observe, Individual UI contains actions for Update, Delete (above requirement) 0 0 0 I did not have any actual update or delete calls. 0
Code Review (binary criteria below, 4 points + bonus) n/a n/a n/a n/a n/a
Individual code quality, review and observe comments in every function, class, or method reviewed. 1 1 1 Our code contains concise comments by every function that allows for easy reading. Our frontend also has comments that allow for our backend devs (myself included) to know what each element is for without doing something that could break the website. 1
BE review, observe if Individual API handles error conditions (ie duplicate user id) 1 1 1 In the creation portion of our site, if you have an email that is already in the database, the function will throw an error. This allows for greater control over what enters and exits our database. Garbage in, garbage out. 1
BE review, observe if Individual API contains GET and POST methods 1 1 1 Our code operates using multiple functions which each store an individual request to our database. As a result, we contain GET methods. We also have authHandlers which handles authentication and POST methods to our database. 1
BE review, observe that Individual code contains database operations that support Create, Read 1 1 1 My code has many calls which contain the database operations GET and POST, or Create and Read. This is then supported by our database, which can actively test write and read methods, and definitely supports it. 1
BE review, observe that Individual code contains database operations that support Update, Delete (above requirement) 1 1 1 I earn this extra point as our code contains database operations that can support Update and Delete function, and our database similarly supports these types of connections. Therefore, I earn this point 1

Part 2: Silent Review by providing Review Ticket to Teacher (4 Points Total)

export const readHandlers = {
    readUserName: async () => {
      setTimeout(() => {
        console.log("why")
      }, 2000);
      if(auth.currentUser){console.log("hello")}
      else{console.log("nothing works")}
      let _uid = auth.currentUser?.uid
      console.log("uid: " + _uid);
      let ret = ""
      try {
      await get(ref(db, '/users/' + _uid)).then(snapshot => ret = snapshot.val().username);
      console.log("ret after change = " + ret);
      }
      catch(error){
        console.log(error);
      }
      return ret
    },
    readAge: async () => {
      setTimeout(() => {
        console.log("why")
      }, 2000);
      if(auth.currentUser){console.log("hello")}
      else{console.log("nothing works")}
      let _uid = auth.currentUser?.uid
      console.log("uid: " + _uid);
      let ret = ""
      try {
      await get(ref(db, '/users/' + _uid+'/vitals')).then(snapshot => ret = snapshot.val().age);
      console.log("ret after change = " + ret);
      }
      catch(error){
        console.log(error);
      }
      return ret
    },
    readPronouns: async () => {
      setTimeout(() => {
        console.log("why")
      }, 2000);
      if(auth.currentUser){console.log("hello")}
      else{console.log("nothing works")}
      let _uid = auth.currentUser?.uid
      console.log("uid: " + _uid);
      let ret = ""
      try {
      await get(ref(db, '/users/' + _uid+'/vitals')).then(snapshot => ret = snapshot.val().pronouns);
      console.log("ret after change = " + ret);
      }
      catch(error){
        console.log(error);
      }
      return ret
    },
  • Guides for Review (include Blog): Notion blog (+0.5)
  • Video: Video On blog (+0.5)
  • GitHub analytics: below (+0.5)

Screenshot 2023-02-27 at 2 31 01 PM

Screenshot 2023-02-27 at 2 31 16 PM

Total: 8/7 and 4/4 = 12/11 total

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant