fix: bad opts passing

nadhifikbarw · Dec 27, 2024 · 53fcac4 · 53fcac4
1 parent cddcdaf
commit 53fcac4
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 12 deletions.
diff --git a/src/comment-query.ts b/src/comment-query.ts
@@ -23,7 +23,7 @@ export class AirtableCommentQuery {
   ) {
     this.table = table;
     this.recordId = recordId;
-    if (this.opts) this.opts = opts;
+    if (opts) this.opts = opts;
   }
 
   async firstPage() {
@@ -74,9 +74,11 @@ export class AirtableCommentQuery {
       {
         query,
         async onEachPage(ctx) {
-          const pageComments = ctx.response?.comments || [];
-          for (const data of pageComments) {
-            comments.push(new AirtableComment(table, recordId, data));
+          if (ctx.response?.comments) {
+            const pageComments = ctx.response.comments;
+            for (const data of pageComments) {
+              comments.push(new AirtableComment(table, recordId, data));
+            }
           }
           return true;
         },

diff --git a/src/query.ts b/src/query.ts
@@ -17,7 +17,7 @@ export class AirtableQuery<TFields extends FieldSet> {
 
   constructor(table: AirtableTable<TFields>, opts?: ListRecordsOptions) {
     this.table = table;
-    if (this.opts) this.opts = opts;
+    if (opts) this.opts = opts;
   }
 
   // TODO: support iterator timeout scenario
@@ -67,9 +67,11 @@ export class AirtableQuery<TFields extends FieldSet> {
       body,
       method: "POST",
       async onEachPage(ctx) {
-        const pageRecords = ctx.response?.records || [];
-        for (const data of pageRecords) {
-          records.push(AirtableRecord.fromData(table, data));
+        if (ctx.response?.records) {
+          const pageRecords = ctx.response.records;
+          for (const data of pageRecords) {
+            records.push(AirtableRecord.fromData(table, data));
+          }
         }
         return true;
       },

diff --git a/src/record.ts b/src/record.ts
@@ -51,10 +51,7 @@ export class AirtableRecord<
     data: RecordData<T>
   ) {
     const rec = new AirtableRecord(table, data.id);
-    rec._data = data;
-    rec.fields = data.fields;
-    rec.createdTime = new Date(data.createdTime);
-    if (data.commentCount) rec.commentCount = data.commentCount;
+    rec.setData(data);
     return rec;
   }