xrb_uint256_to_string does not null-terminate the address string

[gkastel]

https://github.com/clemahieu/raiblocks/blob/0f06b03a1c42655f3217b1a8f2936320a7b0cf67/rai/lib/interface.cpp#L21

[clemahieu]

The idea with this was that someone could put this number in to the middle of a string without having the null character clobber something.

// Convert public/private key bytes 'source' to a 64 byte not-null-terminated hex string 'destination'
void xrb_uint256_to_string (const xrb_uint256 source, char * destination);

[gkastel]

ok thanks. but to_address() uses 65 chars

https://github.com/clemahieu/raiblocks/blob/0f06b03a1c42655f3217b1a8f2936320a7b0cf67/rai/lib/interface.cpp#L24

in the test they are both expecting 65 byte null-terminated buffers:
https://github.com/clemahieu/raiblocks/blob/b328640745cf9c0200bcaba67c44832572bb0fa3/rai/core_test/interface.cpp

[rkeene]

I don't think we're going to reach a decision on this in time for V17.0, moving to the next release which we plan to use for cleanup and can decide how best to handle this.