Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Finish pending to receivable changes for RPCs #3689

Closed
8 tasks done
zhyatt opened this issue Jan 24, 2022 · 2 comments · Fixed by #3753
Closed
8 tasks done

Finish pending to receivable changes for RPCs #3689

zhyatt opened this issue Jan 24, 2022 · 2 comments · Fixed by #3753
Assignees
Labels
documentation This item indicates the need for or supplies updated or expanded documentation rpc Changes related to Remote Procedure Calls
Milestone

Comments

@zhyatt
Copy link
Collaborator

zhyatt commented Jan 24, 2022

The following RPC commands need an alias added and the previous RPC command to be marked as deprecated:

  • accounts_pending deprecated, add accounts_receivable

  • search_pending deprecated, add search_receivable

  • search_pending_all deprecated, add search_receivable_all

  • wallet_pending deprecated, add wallet_receivable

  • account_info and blocks_info RPC command needs the optional pending parameter to be deprecated and receivable parameter added

  • account_info and blocks_info RPC response for both should include both pending and receivable for backwards compatibility

  • ledger and wallet_ledger RPCs need receivable option support, deprecate pending option

  • pending and pending_exists RPCs need to have deprecation = 1 returned

These details were incorrectly noted in the documentation as having been completed in V23 (via PR #3411) but those notes will be removed by nanocurrency/nano-docs#613.

@zhyatt zhyatt added the rpc Changes related to Remote Procedure Calls label Jan 24, 2022
@zhyatt zhyatt added this to the V24.0 milestone Jan 24, 2022
@zhyatt
Copy link
Collaborator Author

zhyatt commented Jan 26, 2022

@shryder Since you did great work on the previous changes, do you have time to help finish these up?

@dsiganos
Copy link
Contributor

@zhyatt The following commands still seem to be using pending option without having support for receivable:

  • ledger
  • wallet_ledger

And I suspect that the following commands do not return the deprecated=true field:

  • pending
  • pending_exists

@zhyatt zhyatt added the documentation This item indicates the need for or supplies updated or expanded documentation label Mar 29, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
documentation This item indicates the need for or supplies updated or expanded documentation rpc Changes related to Remote Procedure Calls
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants